Add support for downloading logs by migration ID #1455
+199
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 1 files 1 suites 10m 25s ⏱️ Results for commit f68edcb. ♻️ This comment has been updated with latest results. |
brianaj
changed the title
Copilot finished reviewing on behalf of
brianaj
December 1, 2025 19:42
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for downloading migration logs using a --migration-id parameter as an alternative to specifying --github-org and --github-repo, addressing the scenario where users have a migration ID but the migration isn't found via org/repo lookup.
Key changes:
- Made
--github-organd--github-repooptional parameters in all three CLI commands (gei, ado2gh, bbs2gh) - Added new
--migration-idoption that allows direct log download by migration ID - Implemented mutual exclusivity validation: either migration-id OR both org/repo must be provided
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/gei/Commands/DownloadLogs/DownloadLogsCommand.cs |
Removed IsRequired = true from GithubRepo and GithubOrg options |
src/Octoshift/Commands/DownloadLogs/DownloadLogsCommandBase.cs |
Added MigrationId option and removed IsRequired from base options |
src/Octoshift/Commands/DownloadLogs/DownloadLogsCommandArgs.cs |
Added MigrationId property to command arguments |
src/Octoshift/Commands/DownloadLogs/DownloadLogsCommandHandler.cs |
Implemented validation and dual-path logic for migration-id vs org/repo lookup |
src/OctoshiftCLI.Tests/gei/Commands/DownloadLogs/DownloadLogsCommandTests.cs |
Updated test to reflect new option count and optional parameters |
src/OctoshiftCLI.Tests/bbs2gh/Commands/DownloadLogs/DownloadLogsCommandTests.cs |
Updated test to reflect new option count and optional parameters |
src/OctoshiftCLI.Tests/ado2gh/Commands/DownloadLogs/DownloadLogsCommandTests.cs |
Updated test to reflect new option count and optional parameters |
RELEASENOTES.md |
Added release note describing the new --migration-id feature |
Comments suppressed due to low confidence (1)
src/Octoshift/Commands/DownloadLogs/DownloadLogsCommandHandler.cs:85
- This assignment to State is useless, since its value is never read.
This assignment to WarningsCount is useless, since its value is never read.
This assignment to FailureReason is useless, since its value is never read.
var (State, RepositoryName, WarningsCount, FailureReason, MigrationLogUrl) = migrationResult.Result;
src/Octoshift/Commands/DownloadLogs/DownloadLogsCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/Octoshift/Commands/DownloadLogs/DownloadLogsCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/Octoshift/Commands/DownloadLogs/DownloadLogsCommandHandler.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…dHandler.cs" This reverts commit 5acd9c4.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… local variable Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for downloading migration logs using a
--migration-idparameter as an alternative to specifying--github-organd--github-repo. This addresses the original issue where users couldn't download logs when they had a migration ID but the migration wasn't found via org/repo lookup.Usage
New migration ID approach:
Existing org/repo approach (unchanged):
ThirdPartyNotices.txt(if applicable)